From 96e6cbe22ff87e36d0505c417b9638ce9b2bbc2c Mon Sep 17 00:00:00 2001 From: Daniel Shahaf Date: Thu, 2 Apr 2020 23:40:52 +0000 Subject: [PATCH] 'main': Fix expansion of positional parameters in `_zsh_highlight_main_highlighter__try_expand_parameter`. As described in the last commit's log message, ${parameter_name_pattern] explicitly matches positional parameters but ${parameters[$MATCH]} expands to nothing in that case (when, e.g., [[ $MATCH == '1' ]]; note this is equality of strings, not integers). As a side effect, this removes the dependency on the zsh/parameter module for expanding parameters. --- highlighters/main/main-highlighter.zsh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/highlighters/main/main-highlighter.zsh b/highlighters/main/main-highlighter.zsh index a190a5f..4f44882 100644 --- a/highlighters/main/main-highlighter.zsh +++ b/highlighters/main/main-highlighter.zsh @@ -448,9 +448,9 @@ _zsh_highlight_main_highlighter__try_expand_parameter() else parameter_name=${arg:1} fi - if [[ $res == none ]] && zmodload -e zsh/parameter && + if [[ $res == none ]] && [[ ${parameter_name} =~ ^${~parameter_name_pattern}$ ]] && - [[ ${parameters[(e)$MATCH]} != *special* ]] + [[ ${(tP)MATCH} != *special* ]] then # Set $arg and update $res. case ${(tP)MATCH} in