From 3829cb460cff65ca8af956db66b697d96076f8e1 Mon Sep 17 00:00:00 2001 From: Juan Quintela Date: Thu, 4 Mar 2010 10:00:37 +0100 Subject: [PATCH] vmdk: share cleanup code cleanup code is identical for error/success cases. Only difference are goto labels. Signed-off-by: Juan Quintela Signed-off-by: Anthony Liguori --- block/vmdk.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 819c1c9fc5..007fca4c70 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -334,18 +334,13 @@ static int vmdk_snapshot_create(const char *filename, const char *backing_file) ret = -errno; goto fail_gd; } - qemu_free(gd_buf); - qemu_free(rgd_buf); + ret = 0; - close(p_fd); - close(snp_fd); - return 0; - - fail_gd: +fail_gd: qemu_free(gd_buf); - fail_rgd: +fail_rgd: qemu_free(rgd_buf); - fail: +fail: close(p_fd); close(snp_fd); return ret;