public/qemu
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

linux-user, bsd-user: Preserve incoming order of environment variables in the target

Browse source 
Do not reverse the order of environment variables in the target environ
array relative to the incoming environ order.  Some testsuites depend on a
specific order, even though it is not defined by any standard.

Signed-off-by: Andreas Schwab <schwab@suse.de>
Reviewed-by: Warner Losh <imp@bsdimp.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <mvmlejfsivd.fsf@suse.de>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
This commit is contained in:
Andreas Schwab 2023-03-29 17:00:06 +02:00 committed by Philippe Mathieu-Daudé
parent fdd0df5340
commit 7f750efcaa
2 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
bsd-user/main.c
View file

@ -295,8 +295,16 @@ int main(int argc, char **argv)
envlist = envlist_create();
/* add current environment into the list */
/*
* add current environment into the list
* envlist_setenv adds to the front of the list; to preserve environ
* order add from back to front
*/
for (wrk = environ; *wrk != NULL; wrk++) {
continue;
}
while (wrk != environ) {
wrk--;
(void) envlist_setenv(envlist, *wrk);
}

10
linux-user/main.c
View file

@ -692,8 +692,16 @@ int main(int argc, char **argv, char **envp)
envlist = envlist_create();
/* add current environment into the list */
/*
* add current environment into the list
* envlist_setenv adds to the front of the list; to preserve environ
* order add from back to front
*/
for (wrk = environ; *wrk != NULL; wrk++) {
continue;
}
while (wrk != environ) {
wrk--;
(void) envlist_setenv(envlist, *wrk);
}