public/qemu
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

esp: use correct type for esp_dma_enable() in sysbus_esp_gpio_demux()

Browse source 
The call to esp_dma_enable() was being made with the SYSBUS_ESP type instead of
the ESP type. This meant that when GPIO 1 was being used to trigger a DMA
request from an external DMA controller, the setting of ESPState's dma_enabled
field would clobber unknown memory whilst the dma_cb callback pointer would
typically return NULL so the DMA request would never start.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20230913204410.65650-2-mark.cave-ayland@ilande.co.uk>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit b86dc5cb0b4105fa8ad29e822ab5d21c589c5ec5)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
This commit is contained in:
Mark Cave-Ayland 2023-09-13 21:44:08 +01:00 committed by Michael Tokarev
parent ee7ce8a949
commit 8194d5827e
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
hw/scsi/esp.c
View file

@ -1395,7 +1395,7 @@ static void sysbus_esp_gpio_demux(void *opaque, int irq, int level)
parent_esp_reset(s, irq, level); parent_esp_reset(s, irq, level);
break; break;
case 1: case 1:
esp_dma_enable(opaque, irq, level); esp_dma_enable(s, irq, level);
break; break;
} }
} }