public/qemu
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

virtio-vga: only enable for specific boards

Browse source 
When virtio-vga was added, the intention was to only support it for
those machines where the firmware does not know about virtio-gpu,
and supported VGA legacy hardware before virtio-{gpu,vga} were
introduced.

The Kconfig switch however enabled virtio-vga for all machines with
a PCI bus, and libvirt then prefers it even on hardware where
virtio-gpu would be preferrable.  At least for now, only enable
virtio-vga for PC, hppa and pSeries machines, as was the case
before Kconfig dependencies were introduced.

Reported-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Paolo Bonzini 2019-03-21 15:29:50 +01:00
parent b7c11e5749
commit 938912a866
4 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
hw/display/Kconfig
View file

@ -100,7 +100,7 @@ config VIRTIO_GPU
config VIRTIO_VGA
bool
default y if PCI_DEVICES
# defaults to "N", enabled by specific boards
depends on VIRTIO_PCI
select VGA

1
hw/hppa/Kconfig
View file

@ -2,6 +2,7 @@ config DINO
bool
imply PCI_DEVICES
imply E1000_PCI
imply VIRTIO_VGA
select PCI
select SERIAL
select ISA_BUS

1
hw/i386/Kconfig
View file

@ -19,6 +19,7 @@ config PC
imply TPM_CRB
imply TPM_TIS
imply VGA_PCI
imply VIRTIO_VGA
select FDC
select I8259
select I8254

1
hw/ppc/Kconfig
View file

@ -2,6 +2,7 @@ config PSERIES
bool
imply PCI_DEVICES
imply TEST_DEVICES
imply VIRTIO_VGA
select DIMM
select PCI
select SPAPR_VSCSI