public/qemu
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

usbnet: Add missing usb_wakeup() call in usbnet_receive()

Browse source 
usbnet_receive() does not currently wake up the USB endpoint, leading
to a dead RX datapath when used with a host controller such as xHCI
that relies on being woken up.

Fix by adding a call to usb_wakeup() at the end of usbnet_receive().

Signed-off-by: Michael Brown <mcb30@ipxe.org>
Message-Id: <20220906183053.3625472-2-mcb30@ipxe.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
This commit is contained in:
Michael Brown 2022-09-06 19:30:50 +01:00 committed by Gerd Hoffmann
parent 145cdaba0f
commit a89003780d
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
hw/usb/dev-network.c
View file

@ -647,6 +647,7 @@ struct USBNetState {
uint8_t in_buf[2048];
USBEndpoint *intr;
USBEndpoint *bulk_in;
char usbstring_mac[13];
NICState *nic;
@ -1317,6 +1318,7 @@ static ssize_t usbnet_receive(NetClientState *nc, const uint8_t *buf, size_t siz
memcpy(in_buf, buf, size);
s->in_len = total_size;
s->in_ptr = 0;
usb_wakeup(s->bulk_in, 0);
return size;
}
@ -1359,6 +1361,7 @@ static void usb_net_realize(USBDevice *dev, Error **errp)
s->filter = 0;
s->vendorid = 0x1234;
s->intr = usb_ep_get(dev, USB_TOKEN_IN, 1);
s->bulk_in = usb_ep_get(dev, USB_TOKEN_IN, 2);
qemu_macaddr_default_if_unset(&s->conf.macaddr);
s->nic = qemu_new_nic(&net_usbnet_info, &s->conf,