dma: Let dma_memory_set() propagate MemTxResult
address_space_write() returns a MemTxResult type. Do not discard it, return it to the caller. Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Li Qiang <liq3ea@gmail.com> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-Id: <20201023151923.3243652-5-philmd@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
parent
9c211ad2ca
commit
bb755f5286
|
@ -123,7 +123,20 @@ static inline int dma_memory_write(AddressSpace *as, dma_addr_t addr,
|
||||||
DMA_DIRECTION_FROM_DEVICE);
|
DMA_DIRECTION_FROM_DEVICE);
|
||||||
}
|
}
|
||||||
|
|
||||||
int dma_memory_set(AddressSpace *as, dma_addr_t addr, uint8_t c, dma_addr_t len);
|
/**
|
||||||
|
* dma_memory_set: Fill memory with a constant byte from DMA controller.
|
||||||
|
*
|
||||||
|
* Return a MemTxResult indicating whether the operation succeeded
|
||||||
|
* or failed (eg unassigned memory, device rejected the transaction,
|
||||||
|
* IOMMU fault).
|
||||||
|
*
|
||||||
|
* @as: #AddressSpace to be accessed
|
||||||
|
* @addr: address within that address space
|
||||||
|
* @c: constant byte to fill the memory
|
||||||
|
* @len: the number of bytes to fill with the constant byte
|
||||||
|
*/
|
||||||
|
MemTxResult dma_memory_set(AddressSpace *as, dma_addr_t addr,
|
||||||
|
uint8_t c, dma_addr_t len);
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* address_space_map: Map a physical memory region into a host virtual address.
|
* address_space_map: Map a physical memory region into a host virtual address.
|
||||||
|
|
|
@ -1,7 +1,7 @@
|
||||||
/*
|
/*
|
||||||
* DMA helper functions
|
* DMA helper functions
|
||||||
*
|
*
|
||||||
* Copyright (c) 2009 Red Hat
|
* Copyright (c) 2009,2020 Red Hat
|
||||||
*
|
*
|
||||||
* This work is licensed under the terms of the GNU General Public License
|
* This work is licensed under the terms of the GNU General Public License
|
||||||
* (GNU GPL), version 2 or later.
|
* (GNU GPL), version 2 or later.
|
||||||
|
@ -18,14 +18,15 @@
|
||||||
|
|
||||||
/* #define DEBUG_IOMMU */
|
/* #define DEBUG_IOMMU */
|
||||||
|
|
||||||
int dma_memory_set(AddressSpace *as, dma_addr_t addr, uint8_t c, dma_addr_t len)
|
MemTxResult dma_memory_set(AddressSpace *as, dma_addr_t addr,
|
||||||
|
uint8_t c, dma_addr_t len)
|
||||||
{
|
{
|
||||||
dma_barrier(as, DMA_DIRECTION_FROM_DEVICE);
|
dma_barrier(as, DMA_DIRECTION_FROM_DEVICE);
|
||||||
|
|
||||||
#define FILLBUF_SIZE 512
|
#define FILLBUF_SIZE 512
|
||||||
uint8_t fillbuf[FILLBUF_SIZE];
|
uint8_t fillbuf[FILLBUF_SIZE];
|
||||||
int l;
|
int l;
|
||||||
bool error = false;
|
MemTxResult error = MEMTX_OK;
|
||||||
|
|
||||||
memset(fillbuf, c, FILLBUF_SIZE);
|
memset(fillbuf, c, FILLBUF_SIZE);
|
||||||
while (len > 0) {
|
while (len > 0) {
|
||||||
|
|
Loading…
Reference in a new issue