qemu/include/hw/intc/allwinner-a10-pic.h
Markus Armbruster ec150c7e09 include: Make headers more self-contained
Back in 2016, we discussed[1] rules for headers, and these were
generally liked:

1. Have a carefully curated header that's included everywhere first.  We
   got that already thanks to Peter: osdep.h.

2. Headers should normally include everything they need beyond osdep.h.
   If exceptions are needed for some reason, they must be documented in
   the header.  If all that's needed from a header is typedefs, put
   those into qemu/typedefs.h instead of including the header.

3. Cyclic inclusion is forbidden.

This patch gets include/ closer to obeying 2.

It's actually extracted from my "[RFC] Baby steps towards saner
headers" series[2], which demonstrates a possible path towards
checking 2 automatically.  It passes the RFC test there.

[1] Message-ID: <87h9g8j57d.fsf@blackfin.pond.sub.org>
    https://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg03345.html
[2] Message-Id: <20190711122827.18970-1-armbru@redhat.com>
    https://lists.nongnu.org/archive/html/qemu-devel/2019-07/msg02715.html

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20190812052359.30071-2-armbru@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
2019-08-16 13:31:51 +02:00

43 lines
1.1 KiB
C

#ifndef ALLWINNER_A10_PIC_H
#define ALLWINNER_A10_PIC_H
#include "hw/sysbus.h"
#define TYPE_AW_A10_PIC "allwinner-a10-pic"
#define AW_A10_PIC(obj) OBJECT_CHECK(AwA10PICState, (obj), TYPE_AW_A10_PIC)
#define AW_A10_PIC_VECTOR 0
#define AW_A10_PIC_BASE_ADDR 4
#define AW_A10_PIC_PROTECT 8
#define AW_A10_PIC_NMI 0xc
#define AW_A10_PIC_IRQ_PENDING 0x10
#define AW_A10_PIC_FIQ_PENDING 0x20
#define AW_A10_PIC_SELECT 0x30
#define AW_A10_PIC_ENABLE 0x40
#define AW_A10_PIC_MASK 0x50
#define AW_A10_PIC_INT_NR 95
#define AW_A10_PIC_REG_NUM DIV_ROUND_UP(AW_A10_PIC_INT_NR, 32)
typedef struct AwA10PICState {
/*< private >*/
SysBusDevice parent_obj;
/*< public >*/
MemoryRegion iomem;
qemu_irq parent_fiq;
qemu_irq parent_irq;
uint32_t vector;
uint32_t base_addr;
uint32_t protect;
uint32_t nmi;
uint32_t irq_pending[AW_A10_PIC_REG_NUM];
uint32_t fiq_pending[AW_A10_PIC_REG_NUM];
uint32_t select[AW_A10_PIC_REG_NUM];
uint32_t enable[AW_A10_PIC_REG_NUM];
uint32_t mask[AW_A10_PIC_REG_NUM];
/*priority setting here*/
} AwA10PICState;
#endif