qemu/target-i386
Markus Armbruster 65cd9064e1 qom: Clean up fragile use of error_is_set() in set() methods
Using error_is_set(ERRP) to find out whether a function failed is
either wrong, fragile, or unnecessarily opaque.  It's wrong when ERRP
may be null, because errors go undetected when it is.  It's fragile
when proving ERRP non-null involves a non-local argument.  Else, it's
unnecessarily opaque (see commit 84d18f0).

I guess the error_is_set(errp) in the ObjectProperty set() methods are
merely fragile right now, because I can't find a call chain that
passes a null errp argument.

Make the code more robust and more obviously correct: receive the
error in a local variable, then propagate it through the parameter.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
2014-05-05 19:08:49 +02:00
..
arch_dump.c
arch_memory_mapping.c
cc_helper.c
cc_helper_template.h
cpu-qom.h
cpu.c qom: Clean up fragile use of error_is_set() in set() methods 2014-05-05 19:08:49 +02:00
cpu.h target-i386: Avoid shifting left into sign bit 2014-03-27 19:22:49 +04:00
excp_helper.c cpu-exec: Change cpu_loop_exit() argument to CPUState 2014-03-13 19:20:47 +01:00
fpu_helper.c
gdbstub.c
helper.c target-i386: x86_cpu_get_phys_page_debug(): support 1GB page translation 2014-03-31 19:06:48 +02:00
helper.h
int_helper.c
ioport-user.c
kvm-stub.c
kvm.c target-i386: Add missing 'static' and 'const' attributes 2014-03-27 19:22:48 +04:00
kvm_i386.h
machine.c target-i386: reorder fields in cpu/msr_hyperv_hypercall subsection 2014-04-05 10:49:05 +01:00
Makefile.objs
mem_helper.c translate-all: Change cpu_restore_state() argument to CPUState 2014-03-13 19:20:47 +01:00
misc_helper.c cputlb: Change tlb_flush_page() argument to CPUState 2014-03-13 19:52:47 +01:00
ops_sse.h
ops_sse_header.h
seg_helper.c exec: Change cpu_abort() argument to CPUState 2014-03-13 19:52:28 +01:00
shift_helper_template.h
smm_helper.c
svm.h
svm_helper.c cputlb: Change tlb_flush() argument to CPUState 2014-03-13 19:52:47 +01:00
TODO
topology.h
translate.c cpu: Move breakpoints field from CPU_COMMON to CPUState 2014-03-13 19:20:47 +01:00